chore: Bump curve25519-dalek to v4, sha3 to v0.10#946
Closed
Xuanwo wants to merge 2 commits intoanza-xyz:masterfrom
Closed
chore: Bump curve25519-dalek to v4, sha3 to v0.10#946Xuanwo wants to merge 2 commits intoanza-xyz:masterfrom
Xuanwo wants to merge 2 commits intoanza-xyz:masterfrom
Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo
commented
Apr 21, 2024
|
|
||
| fn try_from(pod: &PodScalar) -> Result<Self, Self::Error> { | ||
| Scalar::from_canonical_bytes(pod.0).ok_or(Curve25519Error::PodConversion) | ||
| Option::from(Scalar::from_canonical_bytes(pod.0)).ok_or(Curve25519Error::PodConversion) |
Author
There was a problem hiding this comment.
API like Scalar::from_canonical_bytes returns CtOption which doesn't have ok_or API. Do you have better ideas?
|
|
||
| fn try_from(pod: &PodRistrettoPoint) -> Result<Self, Self::Error> { | ||
| CompressedRistretto::from_slice(&pod.0) | ||
| .map_err(|_| Curve25519Error::PodConversion)? |
Author
There was a problem hiding this comment.
It is good to omit the error and returns Curve25519Error::PodConversion directly?
|
Thanks so much for the contribution! I am starting to look at this (sorry for the delay 🙏 ), but it seems like there is a duplicate PR #513 that also upgrades the curve25519-dalek version. Since the other one is an ealier PR, let's wait until how it turns out first. |
|
Closing since this was done with #1693. Thanks for your contribution anyway! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Summary of Changes
Fixes #647
This PR fix #647 by:
Follow-up tasks: