refactor(fs): use builder for initialization of SequentialFileReader#9420
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9420 +/- ##
=======================================
Coverage 82.5% 82.5%
=======================================
Files 895 895
Lines 322338 322361 +23
=======================================
+ Hits 266042 266097 +55
+ Misses 56296 56264 -32 🚀 New features to boost your workflow:
|
brooksprumo
reviewed
Dec 5, 2025
08120b9 to
0537ccd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We need a more advanced way to create io_uring sequential file reader with several tuning options.
The nearest uses for this will be:
DIRECT_IO(we want to reserve ability to turn it off in case of bugs)FIXED(it requires memlock ulimit that is not always available)All those low level options would clutter the API when required to be passed as parameters to constructor functions.
Summary of Changes
SequentialFileReaderBuilder, which uses defaults when created bynew()and allows adjusting parameters and finally building the reader