xtask: crate publish test#9334
Merged
yihau merged 7 commits intoanza-xyz:masterfrom Jan 10, 2026
Merged
Conversation
yihau
force-pushed
the
crate-publish-test
branch
3 times, most recently
from
4743e6c to
f6ecaf5
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9334 +/- ##
=========================================
- Coverage 82.6% 82.5% -0.1%
=========================================
Files 847 848 +1
Lines 317630 317958 +328
=========================================
+ Hits 262477 262600 +123
- Misses 55153 55358 +205 🚀 New features to boost your workflow:
|
Closed
levsha
reviewed
Dec 5, 2025
| @@ -0,0 +1,482 @@ | |||
| use { | |||
There was a problem hiding this comment.
This new code has no test coverage. Shipping the code together with tests makes it easier to also review the code as verifying tests allows to quickly confirm that the code does what it is supposed to do and that expectations what the code is supposed to do match tests.
yihau
force-pushed
the
crate-publish-test
branch
from
3cb1995 to
6c37f25
Compare
yihau
force-pushed
the
crate-publish-test
branch
from
6c37f25 to
ff3dd3a
Compare
|
Ran through the tests and seems to be working correctly. It published all the crates as expected. |
mircea-c
previously approved these changes
Jan 7, 2026
mircea-c
left a comment
mircea-c
left a comment
There was a problem hiding this comment.
OK, this LGTM. I'll stamp again once conflicts are resolved.
yihau
force-pushed
the
crate-publish-test
branch
from
ff3dd3a to
718ecf7
Compare
mircea-c
previously approved these changes
Jan 7, 2026
yihau
force-pushed
the
crate-publish-test
branch
from
718ecf7 to
0b01e67
Compare
mircea-c
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We don't have a robust verification process to confirm crates publish
Summary of Changes
Followed the idea from #6550 and introduced some new commands:
output
output
output: (https://buildkite.com/anza/agave/builds/35883#019ad9ca-aef5-46ab-a45c-ef81af0d5195)
However, it's a 1h test. I will introduce a nightly path in a follow-up PR. This PR focuses on introducing these tools.