Add BLS Pubkey managerment to vote program. by wen-coding · Pull Request #9310 · anza-xyz/agave

wen-coding · 2025-11-27T01:09:14Z

Per SIMD 387, add the following:

Add new init method using VoteInitV2
Add VoteAuthority::VoterWithBLS
Make them controlled by the new feature flag

mergify · 2025-11-27T01:09:48Z

If this PR represents a change to the public RPC API:

Make sure it includes a complementary update to rpc-client/ (example)
Open a follow-up PR to update the JavaScript client @solana/kit (example)

Thank you for keeping the RPC clients in sync with the server API @wen-coding.

mergify · 2025-11-27T01:09:49Z

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

buffalojoec

Nice! This is getting really close.

samkim-crypto

Left some small comments, but looking good overall.

samkim-crypto · 2025-12-03T02:58:21Z

+    bls_proof_of_possession_compressed_bytes: &[u8; BLS_PROOF_OF_POSSESSION_COMPRESSED_SIZE],
+) -> Result<(), InstructionError> {
+    let bls_pubkey_compressed = BLSPubkeyCompressed(*bls_pubkey_compressed_bytes);
+    let bls_pubkey = BLSPubkey::try_from(bls_pubkey_compressed)


The new v2.0.0 interface, I'll make the function signature to also accept byte arrays directly, but we should technically still be able to call verify directly on compressed form, so we don't need extra conversion here and for proof of possession.

bls_proof_of_possession.verify(&bls_pubkey_compressed, Some(&message))

buffalojoec

Looking great! Test coverage looks good, but I left some suggestions on factoring the tests so we get even more coverage and we can also more clearly see what's going on.

The program side looks good from my end. Next we have to get the vote-interface release out and get this branch updated.

mergify · 2025-12-13T08:53:22Z

If this PR represents a change to the public RPC API:

Make sure it includes a complementary update to rpc-client/ (example)
Open a follow-up PR to update the JavaScript client @solana/kit (example)

Thank you for keeping the RPC clients in sync with the server API @wen-coding.

codecov-commenter · 2025-12-16T03:05:10Z

Codecov Report

❌ Patch coverage is 99.31707% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.6%. Comparing base (bcaeadd) to head (ed37139).

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #9310    +/-   ##
========================================
  Coverage    82.6%    82.6%            
========================================
  Files         902      902            
  Lines      323512   324444   +932     
========================================
+ Hits       267318   268261   +943     
+ Misses      56194    56183    -11

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

alexpyattaev · 2025-12-16T18:52:56Z

How did these changes end up here?

Because it's the only way to make tests pass once we upgrade flate2, please review #9557 and I can then rebase.

If we bump flate2 we need to check we are not breaking epochslots.

Yeah definitely, even without flate2 risk, this change itself is dangerous enough, I probably should start test validator after the review goes through

wen-coding · 2025-12-17T05:15:10Z

+        let test_authorize_voter = if with_bls {
+            test_commands.clone().get_matches_from(vec![
+                "test",
+                "vote-authorize-voter-with-bls",


@samkim-crypto @zz-sol I'm a bit confused how to make things work here. I believe this one is for offline signing. In our case I'm doing BLS keypair derivation inside cli parser, so I always need the vote authority keypair passed in. How do we make offline signing work in this case? Is it:

do vote-authorize-voter-with-bls with sign-only to generate the whole message encrypted

So when this thing is called we should have BLS pubkey and PoP without the keypair online
Does that mean I should somehow pass in the BLS pubkey and PoP?

@grod220 this is the part I'm not sure about. The ones with "--sign-only" should work, because I still have ed25519 vote authority keypair there, but how does this piece fit in the picture?

(paste from slack message)

I've done some offline signing CLI work in the past in the context of a multisig transaction. Step 1 was the offline --sign-only mode which output PUBKEY=SIGNATURE and Step 2 had the same parameters, but also with the multiple --signer PUBKEY=SIGNATURE args and broadcasted the tx.

If the tx message includes bls_pubkey and bls_proof_of_possession , but step 2 can't rebuild that same message---you need to pass those as optional args in step 2:

--bls-pubkey <base58> --bls-proof-of-possession <base58>

And those computed values need to be an output of step 1.

Thanks a lot! I fixed the authorized_voter_with_bls, making the new_authorized either pubkey or keypair, depending on whether --bls-pubkey or --bls-proof-of-possession are given.

Somehow I don't think we need similar structure (writing to output and pass in bls-pubkey/bls-proof-of-possession) for create-vote-account-v2, is that expected?

buffalojoec

It looks like there are a few things in-flight still (BLS SDK bump, CLI steps), so I just reviewed the Vote program.

Looking good! I left a few minor test requests, but overall the program implementation looks solid to me.

buffalojoec · 2025-12-18T21:53:55Z

How come these three ABI digests changed?

I think this is due to us linking in new solana-bls-signatures package. These messages aren't used in production yet.

frozen-abi does not check for ABI, it checks for API compatibility in a very paranoid way. Wire format may not have changed at all here.
Our contributor @puhtaytow is working on getting these glitches separated from actual ABI changes. Stay tuned.

…o change.

buffalojoec

Lgtm! The last piece is the BLS dependency and getting another sign-off from Sam about the PoP validation. Once that's all set, I'll approve.

wen-coding · 2025-12-19T17:26:26Z

Lgtm! The last piece is the BLS dependency and getting another sign-off from Sam about the PoP validation. Once that's all set, I'll approve.

@samkim-crypto is on vacation. I chatted with @zz-sol :

I don't believe there is any major work planned for 2.0.0, so this is just a release. Can this PR go in and in the follow up cli PR I change it to 2.0.0 after Sam releases that package?
Zhenfei will help double check the PoP part once gain

zz-sol · 2025-12-19T18:06:22Z

+        BLSProofOfPossession::try_from(bls_proof_of_possession_compressed)
+            .map_err(|_| InstructionError::InvalidArgument)?;
+    let message = generate_pop_message(vote_account_pubkey, bls_pubkey_compressed_bytes);
+    if Ok(true) == bls_proof_of_possession.verify(&bls_pubkey, Some(&message)) {


Oh, i just recalled this

https://github.com/anza-xyz/solana-sdk/pull/496/files/ca5219fa5f09b58a8faaa6cecb55ca9e0374b63c#r2616335767

iiuc this API change will be included in 2.0 @samkim-crypto

Yep this can be simplified with the official release of bls-signatures v2.0, but the current version should be fine for this PR!

samkim-crypto

Sorry for the delay on this. All the PoP and BLS parts look fine to me. When bls-signatures v2.0.0 is cut, I'll create a small PR to simplify some parts, but this shouldn't block this PR from merging (correctness will remain the same). Really great job @wen-coding!

buffalojoec reviewed Nov 27, 2025

View reviewed changes

Comment thread programs/vote/src/vote_processor.rs

Comment thread programs/vote/src/vote_state/mod.rs

wen-coding changed the title ~~Implement simd 387 (POC, please don't review for now)~~ Add BLS Pubkey managerment to vote program. Dec 1, 2025

buffalojoec reviewed Dec 1, 2025

View reviewed changes

wen-coding requested review from samkim-crypto and zz-sol December 1, 2025 19:04

buffalojoec reviewed Dec 2, 2025

View reviewed changes

Comment thread programs/vote/src/vote_state/handler.rs

Comment thread programs/vote/src/vote_state/handler.rs

Comment thread programs/vote/src/vote_processor.rs Outdated

Comment thread programs/vote/src/vote_processor.rs

zz-sol reviewed Dec 2, 2025

View reviewed changes

Comment thread programs/vote/src/vote_state/mod.rs Outdated

Comment thread programs/vote/src/vote_state/mod.rs Outdated

Comment thread programs/vote/src/vote_state/mod.rs

samkim-crypto reviewed Dec 3, 2025

View reviewed changes

buffalojoec reviewed Dec 3, 2025

View reviewed changes

wen-coding force-pushed the implement_simd_387 branch 2 times, most recently from 53e98f4 to 713402e Compare December 11, 2025 05:50

buffalojoec mentioned this pull request Dec 11, 2025

deps: bump vote-interface to 5.0 #9500

Merged

samkim-crypto mentioned this pull request Dec 11, 2025

[bls-signatures] Add support verifying signatures and pop directly as byte arrays anza-xyz/solana-sdk#493

Merged

wen-coding force-pushed the implement_simd_387 branch from 1679a50 to 7a9af4f Compare December 12, 2025 07:42

wen-coding requested a review from a team as a code owner December 15, 2025 22:09

alexpyattaev reviewed Dec 16, 2025

View reviewed changes

feat: SIMD 387 implementation: Add BLS Pubkey management to vote program

f2f46e1

wen-coding force-pushed the implement_simd_387 branch from b9300d2 to f2f46e1 Compare December 17, 2025 03:02

wen-coding commented Dec 17, 2025

View reviewed changes

buffalojoec self-requested a review December 17, 2025 05:56

buffalojoec reviewed Dec 18, 2025

View reviewed changes

wen-coding added 5 commits December 18, 2025 15:37

Make offline signing work for vote_authorize_voter_with_bls.

ac2aeae

Revert unintended change.

1025a31

Revert unintended Cargo.lock change.

3cda71f

Merge branch 'master' into implement_simd_387

55a5eeb

Merge branch 'master' into implement_simd_387

ded7e03

wen-coding added 10 commits December 18, 2025 22:17

Split all cli changes to another PR.

0e2d80c

Disable the feature in TestValidator for now and revert multinode-dem…

f186e76

…o change.

Revert cli related changes.

6060fa5

Merge branch 'master' into implement_simd_387

3dd6a8c

Revert multinode-demo change for now.

655d665

Revert more cli change.

b74ae0b

Fix local-net and deactivate_features test.

4822297

Make linter happy.

a39da34

Try revert more changes.

68f6a56

Also revert bank change.

ed37139

wen-coding requested review from buffalojoec, samkim-crypto and zz-sol December 19, 2025 08:59

buffalojoec reviewed Dec 19, 2025

View reviewed changes

zz-sol reviewed Dec 19, 2025

View reviewed changes

samkim-crypto approved these changes Dec 20, 2025

View reviewed changes

buffalojoec approved these changes Dec 20, 2025

View reviewed changes

wen-coding added this pull request to the merge queue Dec 20, 2025

Merged via the queue into anza-xyz:master with commit bd658b7 Dec 20, 2025
58 checks passed

wen-coding deleted the implement_simd_387 branch December 20, 2025 15:59

wen-coding mentioned this pull request Dec 21, 2025

Add cli for create-vote-account-with-bls and new VoteAuthorize::VoterWithBLS varieties (SIMD 387). #9681

Closed

wen-coding added this to Alpenglow Dec 23, 2025

github-project-automation Bot moved this to Done in Alpenglow Dec 23, 2025

buffalojoec mentioned this pull request Jan 14, 2026

runtime: genesis_utils: remove bls key feature override #10003

Merged

AshwinSekar mentioned this pull request Jan 14, 2026

v3.1: Re-key SIMD-0387: BLS Pubkey Management in Vote Account (backport of #9965) #10034

Closed

This was referenced Jan 23, 2026

SIMD-0387: BLS Pubkey Management in Vote Account firedancer-io/firedancer#7985

Closed

simd-0387: bls pubkey management in vote account firedancer-io/firedancer#8007

Merged

buffalojoec mentioned this pull request Feb 11, 2026

runtime: genesis_utils: remove bls key feature override take 2 #10530

Merged

Conversation

wen-coding commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify Bot commented Nov 27, 2025

Uh oh!

mergify Bot commented Nov 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

buffalojoec left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samkim-crypto left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

buffalojoec left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mergify Bot commented Dec 13, 2025

Uh oh!

codecov-commenter commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

buffalojoec left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wen-coding commented Nov 27, 2025 •

edited

Loading

codecov-commenter commented Dec 16, 2025 •

edited

Loading

samkim-crypto left a comment •

edited

Loading