Skip to content

docs: Add step to update CHANGELOG.md in RELEASE.md#8856

Merged
steviez merged 1 commit intoanza-xyz:masterfrom
steviez:doc_release_changelog
Nov 19, 2025
Merged

docs: Add step to update CHANGELOG.md in RELEASE.md#8856
steviez merged 1 commit intoanza-xyz:masterfrom
steviez:doc_release_changelog

Conversation

@steviez
Copy link
Copy Markdown

@steviez steviez commented Nov 3, 2025

Problem

This is a recurring step that should happen for every release.

Summary of Changes

Document the step so there is less chance of it being forgotten.

In the future, potentially aspire to an automated GH action and/or CI enforcement (ie #8829 (review))

@steviez steviez mentioned this pull request Nov 3, 2025
@steviez steviez requested a review from a team November 3, 2025 18:45
levsha
levsha previously approved these changes Nov 3, 2025
willhickey
willhickey previously approved these changes Nov 5, 2025
Copy link
Copy Markdown

@willhickey willhickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We current have instructions in both RELEASE.md and CHANGELOG.md that are required for creating a new branch. I'm planning to reorganize them (probably by moving everything into RELEASE.md), but this change is an improvement so let's merge it.

@steviez
Copy link
Copy Markdown
Author

steviez commented Nov 5, 2025

We current have instructions in both RELEASE.md and CHANGELOG.md that are required for creating a new branch. I'm planning to reorganize them (probably by moving everything into RELEASE.md), but this change is an improvement so let's merge it.

Don't think I was aware of this block in CHANGELOG.md. I agree that I think it makes sense to consolidate all of our steps into one place.

We don't have to push this PR; we can the reorganization instead. I can try to take a stab at that today while I'm waiting for CI or something

@steviez steviez dismissed stale reviews from willhickey and levsha via 3d55f9e November 10, 2025 23:28
@steviez steviez force-pushed the doc_release_changelog branch from 3310aad to 3d55f9e Compare November 10, 2025 23:28
@steviez steviez requested review from levsha and willhickey November 10, 2025 23:29
@steviez steviez force-pushed the doc_release_changelog branch from 3d55f9e to 83778ab Compare November 10, 2025 23:33
@steviez
Copy link
Copy Markdown
Author

steviez commented Nov 10, 2025

probably by moving everything into RELEASE.md

Took a look and went with this option; think it is too easy to miss the steps buried at the bottom of CHANGELOG. Made the changes, also swapped the order of operations in regards to updating changelog or creating branch first

  • The old instructions implied that one should update the CHANGELOG with new section (ie v4.0 for most recent) before creating the v3.1 branch. We may have done this at one point, but not what we did most recently and not what we should do moving forward IMO
  • So, new instructions say to 1 - Create branch, 2 - Update CHANGELOG for master, and to then make tweaks to CHANGELOG on the release branch.

The commits can't be 1-to-1 for master and beta so this seemed like the right path to avoid pushing anything related to a future branch (ie v4.0) to a current branch (v3.1)

Comment thread RELEASE.md Outdated
Comment thread RELEASE.md Outdated
@steviez steviez force-pushed the doc_release_changelog branch from 83778ab to bbd08ec Compare November 17, 2025 22:42
Copy link
Copy Markdown
Author

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated; force push was just to rebase to tip but I left the review comments in separate commit for ease of review. Will squash pre-merge

Comment thread RELEASE.md Outdated
Comment thread RELEASE.md Outdated
@steviez steviez requested a review from willhickey November 19, 2025 20:00
Copy link
Copy Markdown

@willhickey willhickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RELEASE.md already has a list of steps to perform when creating a new
branch. Updating CHANGELOG.md is one of those steps to perform, so move
the tasks over to make it harder to miss
@steviez steviez force-pushed the doc_release_changelog branch from bbd08ec to 3b87210 Compare November 19, 2025 20:41
@steviez steviez added this pull request to the merge queue Nov 19, 2025
Merged via the queue into anza-xyz:master with commit 6045e25 Nov 19, 2025
11 checks passed
@steviez steviez deleted the doc_release_changelog branch November 19, 2025 20:53
rustopian pushed a commit to rustopian/agave that referenced this pull request Nov 20, 2025
docs: Consolidate changelog update steps into RELEASE.md

RELEASE.md already has a list of steps to perform when creating a new
branch. Updating CHANGELOG.md is one of those steps to perform, so move
the tasks over to make it harder to miss
AvhiMaz pushed a commit to AvhiMaz/agave that referenced this pull request Nov 28, 2025
docs: Consolidate changelog update steps into RELEASE.md

RELEASE.md already has a list of steps to perform when creating a new
branch. Updating CHANGELOG.md is one of those steps to perform, so move
the tasks over to make it harder to miss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants