Skip to content

Add client_id to getClusterNodes RPC response#8741

Closed
DmitriDmitriDmitri wants to merge 2 commits into
anza-xyz:masterfrom
helius-labs:add-client-id-to-rpc
Closed

Add client_id to getClusterNodes RPC response#8741
DmitriDmitriDmitri wants to merge 2 commits into
anza-xyz:masterfrom
helius-labs:add-client-id-to-rpc

Conversation

@DmitriDmitriDmitri
Copy link
Copy Markdown

The getClusterNodes RPC method currently returns node information including version and feature set, but doesn't expose which client is running

Added client_id field to RpcContactInfo struct in rpc-client-types/src/response.rs
Updated getClusterNodes RPC handler in rpc/src/rpc.rs to populate client_id from the node's version info

@mergify mergify Bot requested a review from a team October 28, 2025 22:38
@mergify
Copy link
Copy Markdown

mergify Bot commented Oct 28, 2025

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/kit (example)

Thank you for keeping the RPC clients in sync with the server API @DmitriDmitriDmitri.

@steviez
Copy link
Copy Markdown

steviez commented Oct 29, 2025

There was a previous attempt at this in #7817 that has yet to be reviewed (CC @alannza)

@joncinque
Copy link
Copy Markdown

Closing this in favor of #7817, which also handles CLI changes

@joncinque joncinque closed this Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants