Respect MAX_LEADER_SCHEDULE_STAKES constant#8584
Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom Oct 21, 2025
Merged
Conversation
c283622 to
6e0d961
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8584 +/- ##
=========================================
- Coverage 83.1% 83.1% -0.1%
=========================================
Files 846 846
Lines 368602 368604 +2
=========================================
- Hits 306674 306671 -3
- Misses 61928 61933 +5 🚀 New features to boost your workflow:
|
jstarry
approved these changes
Oct 21, 2025
This was referenced Oct 21, 2025
rustopian
pushed a commit
to rustopian/agave
that referenced
this pull request
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
MAX_LEADER_SCHEDULE_STAKESconstant is not respected. We actually store 6 epochs-worth of stakes, not 5.(The broader goal/context is to reduce the number of epochs in the epoch stakes cache, which eventually gets serialized into the snapshot.)
Note that
MAX_LEADER_SCHEDULE_STAKES = 5was arbitrarily chosen. Here's its origin: solana-labs#7668 (comment).Summary of Changes
Actually respect the constant.