fix receiver dropped in streamer tests#8490
Merged
KirillLykov merged 1 commit intoanza-xyz:masterfrom Oct 17, 2025
Merged
Conversation
KirillLykov
commented
Oct 15, 2025
| check_multiple_writes(receiver, server_address, Some(&client_keypair)).await; | ||
| cancel.cancel(); | ||
| join_handle.await.unwrap(); | ||
| sleep(Duration::from_millis(100)).await; |
Author
There was a problem hiding this comment.
There is no need to wait 100ms after the stop of the streamer because now streamer will wait for all the connections to stop as well.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8490 +/- ##
=========================================
- Coverage 83.1% 83.1% -0.1%
=========================================
Files 848 848
Lines 368263 368266 +3
=========================================
- Hits 306330 306222 -108
- Misses 61933 62044 +111 🚀 New features to boost your workflow:
|
rustopian
pushed a commit
to rustopian/agave
that referenced
this pull request
Nov 20, 2025
fix some tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes some streamer tests that dropped implicitly receiver.
Follow up for #8458
Summary of Changes