Skip to content

Test value inserted for preallocated entry instead of cloned value#8337

Merged
kskalski merged 1 commit intoanza-xyz:masterfrom
kskalski:ks/prealloc_entry_test_clone
Oct 6, 2025
Merged

Test value inserted for preallocated entry instead of cloned value#8337
kskalski merged 1 commit intoanza-xyz:masterfrom
kskalski:ks/prealloc_entry_test_clone

Conversation

@kskalski
Copy link
Copy Markdown

@kskalski kskalski commented Oct 6, 2025

Problem

accounts-index test implements a custom Clone for PreAllocatedAccountMapEntry that is only used for checking first (slot, val) stored in there before inserting to accounts-index map.

Summary of Changes

Make the test actually check the inserted values, not how the values are converted from pre-alloc entry cloned by test-only code.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.2%. Comparing base (7b4f131) to head (3137fd2).

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #8337     +/-   ##
=========================================
- Coverage    83.2%    83.2%   -0.1%     
=========================================
  Files         836      836             
  Lines      367890   367880     -10     
=========================================
- Hits       306231   306216     -15     
- Misses      61659    61664      +5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kskalski kskalski marked this pull request as ready for review October 6, 2025 01:38
Copy link
Copy Markdown

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kskalski kskalski merged commit 214adb6 into anza-xyz:master Oct 6, 2025
43 checks passed
@kskalski kskalski deleted the ks/prealloc_entry_test_clone branch October 6, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants