Skip to content

status-cache: add shuttle tests#8275

Merged
alessandrod merged 1 commit into
anza-xyz:masterfrom
alessandrod:status-cache-tests
Oct 1, 2025
Merged

status-cache: add shuttle tests#8275
alessandrod merged 1 commit into
anza-xyz:masterfrom
alessandrod:status-cache-tests

Conversation

@alessandrod
Copy link
Copy Markdown

Next chunk split out from #3796

This only adds tests, doesn't change any logic.

@alessandrod alessandrod requested a review from Copilot October 1, 2025 02:35
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Shuttle tests to the status cache module for concurrent behavior testing. Shuttle is a deterministic testing framework for finding concurrency bugs by exploring different thread interleavings.

  • Adds conditional compilation support for shuttle testing with feature gates
  • Implements three shuttle test scenarios covering concurrent operations on the status cache
  • Updates CI configuration to run the new shuttle tests

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
runtime/src/status_cache.rs Adds shuttle-specific imports, deterministic key indexing, and comprehensive shuttle test module
runtime/src/serde_snapshot/status_cache.rs Conditionally imports Mutex from shuttle vs std based on feature flag
runtime/Cargo.toml Adds shuttle-test feature and optional shuttle dependency
ci/test-shuttle.sh Extends CI script to run shuttle tests for runtime module

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.2%. Comparing base (617d477) to head (b91e8c9).
⚠️ Report is 2061 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8275   +/-   ##
=======================================
  Coverage    83.2%    83.2%           
=======================================
  Files         836      836           
  Lines      366600   366604    +4     
=======================================
+ Hits       305201   305233   +32     
+ Misses      61399    61371   -28     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@apfitzge apfitzge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment about whether we should be using shuttle's Arc in a spot we're not currently (but using the other shuttle sync types)

Comment thread runtime/src/serde_snapshot/status_cache.rs
@alessandrod alessandrod merged commit 21d88de into anza-xyz:master Oct 1, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants