cli: Move all compute budget code into compute_budget.rs#826
Merged
joncinque merged 3 commits intoanza-xyz:masterfrom Apr 16, 2024
Merged
cli: Move all compute budget code into compute_budget.rs#826joncinque merged 3 commits intoanza-xyz:masterfrom
joncinque merged 3 commits intoanza-xyz:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #826 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 851 851
Lines 231576 231576
=======================================
+ Hits 189473 189505 +32
+ Misses 42103 42071 -32 |
michaelschem
pushed a commit
to michaelschem/agave
that referenced
this pull request
Apr 20, 2024
* Refactor `simulate_and_update_compute_unit_limit` * Move `WithComputeUnitPrice` to `compute_budget` * Move `set_compute_budget_ixs_if_needed`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In preparation to support dynamic compute unit limits in the CLI, it's neater to have everything in a shared
compute_budget.rsfile, where some bits are currently scattered.Summary of Changes
No functional changes to see here, just moving some functions around so they can eventually be reused. Technically a breaking change by removing
compute_unit_priceand restrictingWithComputeUnitPriceto bepub(crate)instead ofpub, but those shouldn't be used externallyFixes #