v3.0: Retry IO on short write in io_uring file creator (backport of #8053)#8173
Merged
Conversation
* Support short writes in io_uring file creator * Handle resource busy err as short write. Update comment. Fix calculating total written for stats * Remove handling of busy error * Add warn for short write (cherry picked from commit a10a2c8)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## v3.0 #8173 +/- ##
=======================================
Coverage 83.4% 83.4%
=======================================
Files 810 810
Lines 365773 365792 +19
=======================================
+ Hits 305395 305435 +40
+ Misses 60378 60357 -21 🚀 New features to boost your workflow:
|
t-nelson
reviewed
Sep 24, 2025
t-nelson
approved these changes
Sep 24, 2025
alessandrod
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As reported in #8036 (comment) ubuntu 22 with 5.15 kernel and ZFS filesystem experiences error due to short writes.
It's not completely clear which kernel / FS combination give 100% guarantee of not returning short write, this comment axboe/liburing#766 (comment) suggests 5.15 fixed some issues, but given reports from the wild it's worth fixing.
Summary of Changes
Re-submit write when getting short write (unless
Okwith 0-size write happens, which is treated as hard error)Fixes #8036
This is an automatic backport of pull request #8053 done by [Mergify](https://mergify.com).