runtime: Remove ops::Add implementation for RewardAccumulator#8156
Merged
vadorovsky merged 1 commit intoanza-xyz:masterfrom Sep 24, 2025
Merged
runtime: Remove ops::Add implementation for RewardAccumulator#8156vadorovsky merged 1 commit intoanza-xyz:masterfrom
ops::Add implementation for RewardAccumulator#8156vadorovsky merged 1 commit intoanza-xyz:masterfrom
Conversation
vadorovsky
force-pushed
the
reward-accumulator-add
branch
2 times, most recently
from
099fb94 to
2be5459
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8156 +/- ##
=======================================
Coverage 83.0% 83.0%
=======================================
Files 826 826
Lines 362298 362298
=======================================
+ Hits 300774 300789 +15
+ Misses 61524 61509 -15 🚀 New features to boost your workflow:
|
t-nelson
reviewed
Sep 23, 2025
Using `+` to merge different `RewardAccumulator` instances is not intuitive for everyone. Replace the `ops::Add` implementation with a custom `merge` method.
vadorovsky
force-pushed
the
reward-accumulator-add
branch
from
2be5459 to
0cacddc
Compare
t-nelson
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Using
+to merge differentRewardAccumulatorinstances is not intuitive for everyone.Summary of Changes
Replace the
ops::Addimplementation with a custommergemethod.