Renames AccountsBackgroundService's thread#8140
Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom Sep 22, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8140 +/- ##
=========================================
- Coverage 83.0% 83.0% -0.1%
=========================================
Files 825 825
Lines 361899 361899
=========================================
- Hits 300499 300421 -78
- Misses 61400 61478 +78 🚀 New features to boost your workflow:
|
Author
|
@steviez - requesting your review as "thread czar" |
steviez
approved these changes
Sep 22, 2025
steviez
left a comment
There was a problem hiding this comment.
requesting your review as "thread czar"
😆
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The AccountsBackgroundService thread has a non-ideal name, "solBgAccounts".
Since we also have the accounts-db foreground and background thread pools, there's some ambiguity between the ABS thread and the bg thread pool, named "solAcctsDbBg". It's unlikely that someone without preexisting knowledge will understand the difference.
There is precedent for naming the thread of services as "Svc", but ABS does not follow this convention. Here's some examples:
Summary of Changes
Rename the ABS thread to "solAcctsBgSvc".