Refactor handle_reclaims to avoid option wrap/unwrap #8113
Merged
HaoranYi merged 1 commit intoanza-xyz:masterfrom Sep 19, 2025
Merged
Refactor handle_reclaims to avoid option wrap/unwrap #8113HaoranYi merged 1 commit intoanza-xyz:masterfrom
HaoranYi merged 1 commit intoanza-xyz:masterfrom
Conversation
filter bug revert update index change
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8113 +/- ##
=========================================
- Coverage 82.9% 82.9% -0.1%
=========================================
Files 823 823
Lines 360470 360469 -1
=========================================
- Hits 299068 299060 -8
- Misses 61402 61409 +7 🚀 New features to boost your workflow:
|
brooksprumo
approved these changes
Sep 19, 2025
| MarkAccountsObsolete::No, | ||
| ); | ||
| measure.stop(); | ||
| debug!("{measure}"); |
There was a problem hiding this comment.
This PR also is removing this debug log.
I think it's fine, but not something I was expecting to see based on the PR's title and description.
Author
There was a problem hiding this comment.
Good catch — I have updated the description to mention the removal of that debug log as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Split from #7624
This PR refactors handle_reclaims function and its callers to eliminate option wrapper.
Summary of Changes
Fixes #