chained cleanup continuation; subsequent to #8079#8111
Merged
steviez merged 15 commits intoanza-xyz:masterfrom Oct 9, 2025
Merged
chained cleanup continuation; subsequent to #8079#8111steviez merged 15 commits intoanza-xyz:masterfrom
steviez merged 15 commits intoanza-xyz:masterfrom
Conversation
puhtaytow
force-pushed
the
chained-cleanup-continuation-1
branch
4 times, most recently
from
9767779 to
6cc3c19
Compare
puhtaytow
force-pushed
the
chained-cleanup-continuation-1
branch
4 times, most recently
from
0432981 to
fad2ef9
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8111 +/- ##
========================================
Coverage 83.2% 83.2%
========================================
Files 846 846
Lines 369245 369052 -193
========================================
- Hits 307350 307209 -141
+ Misses 61895 61843 -52 🚀 New features to boost your workflow:
|
puhtaytow
changed the title
Author
|
hey @steviez @AshwinSekar could i please you to have a look when you find a minute? that would be helpful to move forward with the api changes which you suggested the other day 🙏 pretty please |
steviez
reviewed
Oct 9, 2025
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
Overall looking good, just a couple nits to keep consistency with the rest of the codebase
…with_index_and_chained_merkle_and_last_in_slot
…hreds_from_entries
…erkle_shreds_for_tests
…ake_shreds_from_data
puhtaytow
force-pushed
the
chained-cleanup-continuation-1
branch
from
8b75f28 to
4ab4936
Compare
steviez
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There is still remaining parts of code that allows for unchained shreds. The unchained shreds are nomore in production.
Cleaning it all at once would result in hard to review PR, that is why taking iterative approach seem to be the way.
This PR is subsequent to #8079
Summary of Changes
removed chained switch from params in
ledger/shred/merkle/run_make_shreds_from_datatest_make_shreds_from_datatest_make_shreds_from_data_randtest_make_shreds_from_data_paranoidremoved option from
chained_merkle_rootparam inledger/shred/merkle/make_shreds_from_dataremoved chained switch from params in
ledger/shred/merkle/shred_leftover_dataremoved chained switch from params in
ledger/shred/merkle/get_merkle_rootbothShredDataandShredCodevariantsledger/shred/wire/get_signed_dataledger/shred/wire/get_merkle_rootledger/shred/wire/resign_shredremoved chained field from
ledger/shred/ShredVariantboth variants; fixed code around it