feat: discard shreds that unexpectedly specify data complete#8099
Merged
ksn6 merged 8 commits intoOct 9, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8099 +/- ##
========================================
Coverage 83.2% 83.2%
========================================
Files 846 846
Lines 369245 369386 +141
========================================
+ Hits 307350 307475 +125
- Misses 61895 61911 +16 🚀 New features to boost your workflow:
|
ksn6
force-pushed
the
discard-shreds-with-invalid-data-complete-flag
branch
from
749c17e to
3275259
Compare
AshwinSekar
reviewed
Sep 22, 2025
ksn6
force-pushed
the
discard-shreds-with-invalid-data-complete-flag
branch
from
cfae172 to
a597eed
Compare
ksn6
force-pushed
the
discard-shreds-with-invalid-data-complete-flag
branch
from
a597eed to
cfff247
Compare
AshwinSekar
reviewed
Oct 7, 2025
ksn6
force-pushed
the
discard-shreds-with-invalid-data-complete-flag
branch
from
92a52ac to
9b621b4
Compare
ksn6
commented
Oct 8, 2025
| /*************** ADD NEW FEATURES HERE ***************/ | ||
| ( | ||
| discard_unexpected_data_complete_shreds::id(), | ||
| "SIMD-0337: Markers for Alpenglow Fast Leader Handover, DATA_COMPLETE_SHRED placement \ |
Author
There was a problem hiding this comment.
I'll introduce the markers themselves in a separate PR, hence the qualification here. Let me know if this comment is too long.
ksn6
force-pushed
the
discard-shreds-with-invalid-data-complete-flag
branch
from
e7c79a8 to
cab389e
Compare
AshwinSekar
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the
DATA_COMPLETE_SHREDflag can theoretically be set on any data shred within an FEC set, though in practice it marks FEC set boundaries.By enforcing
DATA_COMPLETE_SHREDplacement only on the last data shred in each FEC set, validators can detectBlockComponentboundaries during online shred ingestion, necessary for Alpenglow Fast Leader Handover.This PR addresses solana-foundation/solana-improvement-documents#337.