Skip to content

Revert "fix: enable on-demand leader schedule computation in get_slot…#7917

Merged
KirillLykov merged 1 commit intoanza-xyz:masterfrom
KirillLykov:klykov/revert-7765
Sep 8, 2025
Merged

Revert "fix: enable on-demand leader schedule computation in get_slot…#7917
KirillLykov merged 1 commit intoanza-xyz:masterfrom
KirillLykov:klykov/revert-7765

Conversation

@KirillLykov
Copy link
Copy Markdown

@KirillLykov KirillLykov commented Sep 5, 2025

The original change was to fix the problem with get_slot_leaders.

After looking deeper into it, I agree that the fix was incorrect, the test is incorrect, and, hence, the issue requires additional investigation.

This reverts commit ce1e9b3.

@KirillLykov KirillLykov requested a review from t-nelson September 5, 2025 15:56
@mergify
Copy link
Copy Markdown

mergify Bot commented Sep 5, 2025

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/kit (example)

Thank you for keeping the RPC clients in sync with the server API @KirillLykov.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.1%. Comparing base (43b06cb) to head (1d33386).
⚠️ Report is 2282 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7917   +/-   ##
=======================================
  Coverage    83.1%    83.1%           
=======================================
  Files         810      810           
  Lines      357414   357386   -28     
=======================================
- Hits       297133   297114   -19     
+ Misses      60281    60272    -9     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KirillLykov KirillLykov merged commit 1ba20ad into anza-xyz:master Sep 8, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants