Skip to content

tpu-client-next: test_config picks random port fix#7800

Merged
alexpyattaev merged 1 commit intoanza-xyz:masterfrom
puhtaytow:tpu-client-next-0
Sep 1, 2025
Merged

tpu-client-next: test_config picks random port fix#7800
alexpyattaev merged 1 commit intoanza-xyz:masterfrom
puhtaytow:tpu-client-next-0

Conversation

@puhtaytow
Copy link
Copy Markdown

@puhtaytow puhtaytow commented Aug 29, 2025

Problem

The test_config picks a random port (0), which might conflict with ports allocated deterministic way thru unique_port_range_for_tests.

Summary of Changes

  • The function now picks non-overlapping port thru unique_port_range_for_tests
  • Ipv4Addr::new(127, 0, 0, 1) was replaced by IpAddr::V4(Ipv4Addr::LOCALHOST) for consistency reason.

@puhtaytow puhtaytow marked this pull request as draft August 29, 2025 17:25
@mergify mergify Bot requested a review from a team August 29, 2025 17:25
@puhtaytow puhtaytow changed the title tpu-client-next: test_config takes unique non-overlapping port (and more) tpu-client-next: test_config pick random port fix (and more) Aug 29, 2025
@puhtaytow puhtaytow changed the title tpu-client-next: test_config pick random port fix (and more) tpu-client-next: test_config picks random port fix (and more) Aug 29, 2025
@alexpyattaev alexpyattaev added the CI Pull Request is ready to enter CI label Aug 29, 2025
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Aug 29, 2025
@puhtaytow puhtaytow changed the title tpu-client-next: test_config picks random port fix (and more) tpu-client-next: test_config picks random port fix Aug 29, 2025
@puhtaytow puhtaytow marked this pull request as ready for review August 29, 2025 17:44
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.0%. Comparing base (77f600b) to head (f7ce914).
⚠️ Report is 2334 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #7800     +/-   ##
=========================================
- Coverage    83.0%    83.0%   -0.1%     
=========================================
  Files         812      812             
  Lines      357199   357199             
=========================================
- Hits       296801   296754     -47     
- Misses      60398    60445     +47     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@alexpyattaev alexpyattaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES PLEASE

@alexpyattaev alexpyattaev merged commit 57a7ee1 into anza-xyz:master Sep 1, 2025
47 checks passed
@puhtaytow puhtaytow deleted the tpu-client-next-0 branch September 1, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants