v2.3: fix: enable on-demand leader schedule computation in get_slot_leaders (backport of #7765)#7798
Closed
mergify[bot] wants to merge 1 commit intov2.3from
Closed
v2.3: fix: enable on-demand leader schedule computation in get_slot_leaders (backport of #7765)#7798mergify[bot] wants to merge 1 commit intov2.3from
mergify[bot] wants to merge 1 commit intov2.3from
Conversation
…#7765) get_slot_leaders RPC was failing with "Invalid slot range: leader schedule for epoch X is unavailable" for approximately 31 slots during every epoch transition. This PR fixes it by doing the following: * Add fallback to leader_schedule_utils::leader_schedule() on cache miss * Enables on-demand computation when bank has stake information available * Preserves all existing behavior and error handling * No performance impact for cached schedules (cherry picked from commit ce1e9b3)
Author
|
To address why I think it worth backporting -- because this long existing bug breaks leader targeting for clients using ConnectionCache (or tpu-client-next with default leader targeting) after the epoch change. |
|
lets backport it only on 3.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix get_slot_leaders epoch transition failures
Problem
get_slot_leadersRPC was failing with "Invalid slot range: leader schedule for epoch X is unavailable" for approximately 31 slots during every epoch transition. This occurred because:get_slot_leadersonly checkedleader_schedule_cache.get_epoch_leader_schedule(epoch)Solution
Closes #6845 , can you pls check. @KirillLykov
This is an automatic backport of pull request #7765 done by [Mergify](https://mergify.com).