Add obsolete account test support to geyser

[roryharr]

Problem

Geyser tests expect that clean hasn't been run, and it accomplishes this by flushing slots individually. With obsolete accounts, clean is still run in this scenario, leading to a test failure.

Summary of Changes

• Switch to a version of flush_write_cache that does not perform clean. This assumes that the test is attempting to simulate on going scans during flush.

Fixes #

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.0%. Comparing base (1efc488) to head (e55f2db).
⚠️ Report is 2383 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #7714   +/-   ##
=======================================
  Coverage    83.0%    83.0%           
=======================================
  Files         812      812           
  Lines      357076   357088   +12     
=======================================
+ Hits       296666   296698   +32     
+ Misses      60410    60390   -20     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[brooksprumo]

This assumes that the test is attempting to simulate on going scans during flush.

Wdym here, I'm not sure I follow? The test is w.r.t. geyser's account notification at startup from snapshot, so there is no foreground transaction replay nor rpc request handling yet running.

[brooksprumo]

[roryharr]

This assumes that the test is attempting to simulate on going scans during flush.

Wdym here, I'm not sure I follow? The test is w.r.t. geyser's account notification at startup from snapshot, so there is no foreground transaction replay nor rpc request handling yet running.

Will post this here in case anyone is wondering in the future!

What I mean to say is that this is simulating scans prior to the restart. It's forcing every slot to be fully flushed and not cleaned so multiple versions of the accounts are guaranteed to be present.

In a non RPC validator, not all older version of accounts will be found during replay as they will be cleaned/shrunk etc...

[brooksprumo]

this is simulating scans prior to the restart.

What do you mean here by "scans"?

It's forcing every slot to be fully flushed and not cleaned so multiple versions of the accounts are guaranteed to be present.

Yeah, the test is making storage files for the test. But that's all just the setup, so we can change it to still end up with storages that have duplicates across slots.

In a non RPC validator, not all older version of accounts will be found during replay as they will be cleaned/shrunk etc...

I'm not sure I follow this part either. This test is exercising geyser account notifications for startup, which happens before replay begins.