Skip to content

validator: Resolve Rust 1.88 clippy lints and format strings#7582

Merged
steviez merged 7 commits intoanza-xyz:masterfrom
steviez:rust_1.88_val
Aug 20, 2025
Merged

validator: Resolve Rust 1.88 clippy lints and format strings#7582
steviez merged 7 commits intoanza-xyz:masterfrom
steviez:rust_1.88_val

Conversation

@steviez
Copy link
Copy Markdown

@steviez steviez commented Aug 18, 2025

Problem

Working towards #6850, broken out from #6854

Summary of Changes

  • Run cargo clippy --fix --tests with Rust 1.88.0 set in rust-toolchain.toml
    • These should only be instances of uninlined_format_args
  • Run cargo fmt with format_strings = true set in rustfmt.toml

@steviez steviez force-pushed the rust_1.88_val branch 2 times, most recently from c09abad to b5fc035 Compare August 20, 2025 03:55
Comment thread validator/src/bootstrap.rs Outdated
Comment thread validator/src/bootstrap.rs
Comment thread validator/src/commands/run/args.rs
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 75.10373% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.4%. Comparing base (61cc874) to head (b675f43).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7582   +/-   ##
=======================================
  Coverage    83.4%    83.4%           
=======================================
  Files         813      813           
  Lines      365104   365089   -15     
=======================================
+ Hits       304530   304568   +38     
+ Misses      60574    60521   -53     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread validator/src/bootstrap.rs Outdated
Comment thread validator/src/bootstrap.rs
Comment thread validator/src/commands/exit/mod.rs
Comment thread validator/src/commands/run/args.rs
Comment thread validator/src/commands/repair_whitelist/mod.rs
Comment thread validator/src/commands/run/execute.rs Outdated
Copy link
Copy Markdown

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@steviez steviez merged commit be4d14f into anza-xyz:master Aug 20, 2025
43 checks passed
@steviez steviez deleted the rust_1.88_val branch August 20, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants