Skip to content

Revert "deps: Bump all sdk and spl crates to v3 compatibility (#7492)"#7556

Merged
steviez merged 1 commit intoanza-xyz:masterfrom
joncinque:revert-sdkv3
Aug 16, 2025
Merged

Revert "deps: Bump all sdk and spl crates to v3 compatibility (#7492)"#7556
steviez merged 1 commit intoanza-xyz:masterfrom
joncinque:revert-sdkv3

Conversation

@joncinque
Copy link
Copy Markdown

This reverts commit 06464c5.

Problem

The SDK bump done with #7492 introduces an incompatibility with the status cache in snapshots because InstructionError removed the string part of its BorshIoError.

Summary of Changes

Revert the change to make master work again.

@joncinque joncinque requested a review from brooksprumo August 15, 2025 19:40
@joncinque joncinque requested a review from a team as a code owner August 15, 2025 19:40
@mergify
Copy link
Copy Markdown

mergify Bot commented Aug 15, 2025

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/kit (example)

Thank you for keeping the RPC clients in sync with the server API @joncinque.

@mergify
Copy link
Copy Markdown

mergify Bot commented Aug 15, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@mergify
Copy link
Copy Markdown

mergify Bot commented Aug 15, 2025

For your information, the zk-keygen and zk-sdk directories are
scheduled to be relocated to solana-program/zk-elgamal-proof in a
separate repository. Additionally, the zk-token-sdk directory will
be removed. Please take these upcoming changes into account when
making modifications.

Copy link
Copy Markdown

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry 😢

@joncinque joncinque added the automerge automerge Merge this Pull Request automatically once CI passes label Aug 15, 2025
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.36145% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.4%. Comparing base (f6b92ef) to head (2e86546).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #7556    +/-   ##
========================================
  Coverage    83.4%    83.4%            
========================================
  Files         811      811            
  Lines      365013   364882   -131     
========================================
- Hits       304488   304421    -67     
+ Misses      60525    60461    -64     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joncinque joncinque removed the automerge automerge Merge this Pull Request automatically once CI passes label Aug 15, 2025
@joncinque joncinque marked this pull request as draft August 16, 2025 12:26
@steviez
Copy link
Copy Markdown

steviez commented Aug 16, 2025

We didn't get a review of #7559 in quickly enough, and some of the canaries already got into a poor state due to the incompatibility so going to merge this

@steviez steviez marked this pull request as ready for review August 16, 2025 20:47
@steviez steviez requested a review from a team as a code owner August 16, 2025 20:47
Copy link
Copy Markdown

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping this to get master back into a good state

@steviez steviez merged commit f149dec into anza-xyz:master Aug 16, 2025
53 checks passed
@joncinque joncinque deleted the revert-sdkv3 branch August 17, 2025 22:34
joncinque added a commit that referenced this pull request Aug 20, 2025
#7592)

* Reapply "deps: Bump all sdk and spl crates to v3 compatibility (#7492)" (#7556)

This reverts commit f149dec.

* Update gossip test hash and random key generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants