svm repo split: fork measure#7441
Merged
buffalojoec merged 1 commit intoanza-xyz:masterfrom Aug 11, 2025
Merged
Conversation
|
The Firedancer team maintains a line-for-line reimplementation of the |
4f01451 to
3c171eb
Compare
3c171eb to
50ec253
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7441 +/- ##
========================================
Coverage 83.2% 83.3%
========================================
Files 798 800 +2
Lines 362715 362873 +158
========================================
+ Hits 302122 302290 +168
+ Misses 60593 60583 -10 🚀 New features to boost your workflow:
|
LucasSte
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
solana-measurecrate is a simple utility lib that's used across the validator to measure duration. It's not specific to any one component or domain of Agave, so it doesn't really make sense to live in SVM and have Agave import it.Instead, since the crate is so simple and has no dependencies, it's actually easier to just fork it and maintain a separate version of
solana-measurein the new SVM repo (solana-svm-measure).Part of #7317