Skip to content

svm repo split: fork measure#7441

Merged
buffalojoec merged 1 commit intoanza-xyz:masterfrom
buffalojoec:svm-repo-split-fork-measure
Aug 11, 2025
Merged

svm repo split: fork measure#7441
buffalojoec merged 1 commit intoanza-xyz:masterfrom
buffalojoec:svm-repo-split-fork-measure

Conversation

@buffalojoec
Copy link
Copy Markdown

The solana-measure crate is a simple utility lib that's used across the validator to measure duration. It's not specific to any one component or domain of Agave, so it doesn't really make sense to live in SVM and have Agave import it.

Instead, since the crate is so simple and has no dependencies, it's actually easier to just fork it and maintain a separate version of solana-measure in the new SVM repo (solana-svm-measure).

Part of #7317

@mergify
Copy link
Copy Markdown

mergify Bot commented Aug 10, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@buffalojoec buffalojoec force-pushed the svm-repo-split-fork-measure branch from 4f01451 to 3c171eb Compare August 11, 2025 08:41
@buffalojoec buffalojoec force-pushed the svm-repo-split-fork-measure branch from 3c171eb to 50ec253 Compare August 11, 2025 09:52
@buffalojoec buffalojoec marked this pull request as ready for review August 11, 2025 09:53
@buffalojoec buffalojoec requested a review from a team as a code owner August 11, 2025 09:53
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.40506% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.3%. Comparing base (87a97a3) to head (50ec253).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #7441    +/-   ##
========================================
  Coverage    83.2%    83.3%            
========================================
  Files         798      800     +2     
  Lines      362715   362873   +158     
========================================
+ Hits       302122   302290   +168     
+ Misses      60593    60583    -10     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@buffalojoec buffalojoec merged commit 5cad0f1 into anza-xyz:master Aug 11, 2025
51 checks passed
@buffalojoec buffalojoec deleted the svm-repo-split-fork-measure branch August 11, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants