bench-tps: Resolve Rust 1.88 clippy lints and format strings#7435
Merged
steviez merged 2 commits intoanza-xyz:masterfrom Aug 9, 2025
Merged
bench-tps: Resolve Rust 1.88 clippy lints and format strings#7435steviez merged 2 commits intoanza-xyz:masterfrom
steviez merged 2 commits intoanza-xyz:masterfrom
Conversation
steviez
commented
Aug 9, 2025
| "\nAverage max TPS: {:.2}, {} nodes had 0 TPS", | ||
| average_max, nodes_with_zero_tps | ||
| ); | ||
| info!("\nAverage max TPS: {average_max:.2}, {nodes_with_zero_tps} nodes had 0 TPS"); |
Author
There was a problem hiding this comment.
I'm wondering if the leading newline should be here but gonna leave for this PR I think
| }; | ||
| info!( | ||
| "\nHighest TPS: {:.2} sampling period {}s max transactions: {} clients: {} drop rate: {:.2}", | ||
| "\nHighest TPS: {:.2} sampling period {}s max transactions: {} clients: {} drop rate: \ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7435 +/- ##
=======================================
Coverage 83.2% 83.3%
=======================================
Files 798 798
Lines 363025 363025
=======================================
+ Hits 302379 302431 +52
+ Misses 60646 60594 -52 🚀 New features to boost your workflow:
|
brooksprumo
approved these changes
Aug 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Working towards #6850, broken out from #6854
Summary of Changes
cargo clippy --fix --testswith Rust 1.88.0 set inrust-toolchain.tomluninlined_format_argscargo fmtwithformat_strings = trueset inrustfmt.toml