v2.3: ci: ensure bootstrap node is ready before starting other nodes (backport of #7321)#7382
Merged
v2.3: ci: ensure bootstrap node is ready before starting other nodes (backport of #7321)#7382
Conversation
(cherry picked from commit e0b720b)
steviez
approved these changes
Aug 7, 2025
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
Hopefully not too many more v2.3 BP's, but doesn't hurt to have this so LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
context: https://discord.com/channels/428295358100013066/560503042458517505/1402093272872128613
localnet test is flaky
Summary of Changes
in the
startNodesfunction, we have a comment that makes sense, but the actual logic doesn’t quite align with it.let’s say we have three nodes: the bootstrap node, node 1, and node 2. the current logic starts the nodes in order: first the bootstrap node (index 0), then node 1 (index 1), and so on. however, when starting node 1, the code waits for its own init-complete file instead of checking if the bootstrap node (node 0) is ready. I’ve moved the init-complete check to the top of the loop. this way, when we start node 1, we’ll correctly wait for node 0’s init-complete log (the bootstrap node) before proceeding
This is an automatic backport of pull request #7321 done by Mergify.