PohRecorder - sharable tick heights#7355
Conversation
| // Uses the flag of u64::MAX to indicate None; this does not | ||
| // need to be observable outside of PohRecorder. | ||
| #[derive(Clone)] | ||
| pub struct SharedLeaderFirstTickHeight(Arc<AtomicU64>); |
There was a problem hiding this comment.
Thought about having the same struct as above, but the loading is different since this can be None (via u64::MAX flag).
Thought cleaner to just separate them, even though they are very similar. Will also make it a bit harder to confuse the two once the shared structs are cloned outside of PohRecorder.
|
This, with other recent changes, can allow us to make
until alpenglow**. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7355 +/- ##
=======================================
Coverage 83.2% 83.2%
=======================================
Files 797 797
Lines 361115 361154 +39
=======================================
+ Hits 300699 300760 +61
+ Misses 60416 60394 -22 🚀 New features to boost your workflow:
|
|
#7372 is a follow-up to this change. |
Problem
Summary of Changes
tick_heightandleader_first_tick_heightintoArc<AtomicU64>(flag for None)Fixes #