Renames verify_accounts_lt_hash_us metric#7339
Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom Aug 6, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7339 +/- ##
=======================================
Coverage 83.2% 83.2%
=======================================
Files 797 797
Lines 361115 361115
=======================================
+ Hits 300698 300699 +1
+ Misses 60417 60416 -1 🚀 New features to boost your workflow:
|
4bc98b4 to
b054fad
Compare
roryharr
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
verify_accounts_lt_hash_usmetric name was to disambiguate it from the merkle-based accounts hash verification. Now that merkle-based accounts hashing is gone, we don't need that disambiguation anymore.To be more clear, this metric is calculating the accounts lt hash. The verification happens after the calculation. So the name of the metric is slightly incorrect and could be made clearer.
Summary of Changes
Rename it.