Skip to content

Renames verify_accounts_lt_hash_us metric#7339

Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo:verify-accounts/metrics
Aug 6, 2025
Merged

Renames verify_accounts_lt_hash_us metric#7339
brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo:verify-accounts/metrics

Conversation

@brooksprumo
Copy link
Copy Markdown

@brooksprumo brooksprumo commented Aug 6, 2025

Problem

The verify_accounts_lt_hash_us metric name was to disambiguate it from the merkle-based accounts hash verification. Now that merkle-based accounts hashing is gone, we don't need that disambiguation anymore.

To be more clear, this metric is calculating the accounts lt hash. The verification happens after the calculation. So the name of the metric is slightly incorrect and could be made clearer.

Summary of Changes

Rename it.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.2%. Comparing base (dbb0c6d) to head (b054fad).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7339   +/-   ##
=======================================
  Coverage    83.2%    83.2%           
=======================================
  Files         797      797           
  Lines      361115   361115           
=======================================
+ Hits       300698   300699    +1     
+ Misses      60417    60416    -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brooksprumo brooksprumo force-pushed the verify-accounts/metrics branch from 4bc98b4 to b054fad Compare August 6, 2025 16:03
@brooksprumo brooksprumo marked this pull request as ready for review August 6, 2025 16:06
@brooksprumo brooksprumo requested a review from roryharr August 6, 2025 16:06
@brooksprumo brooksprumo merged commit 6e14749 into anza-xyz:master Aug 6, 2025
41 checks passed
@brooksprumo brooksprumo deleted the verify-accounts/metrics branch August 6, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants