Moves startup accounts verification thread pool creation#7326
Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom Aug 5, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7326 +/- ##
=========================================
- Coverage 83.0% 83.0% -0.1%
=========================================
Files 801 801
Lines 362250 362245 -5
=========================================
- Hits 300792 300779 -13
- Misses 61458 61466 +8 🚀 New features to boost your workflow:
|
roryharr
reviewed
Aug 5, 2025
| let start = Instant::now(); | ||
| let thread_pool_hash = make_hash_thread_pool(num_hash_threads); | ||
| let thread_pool = { | ||
| let num_threads = accounts_db_ |
There was a problem hiding this comment.
Will this be moved later? This seems like it should be part of the bank now.
Author
There was a problem hiding this comment.
Yes, that's the plan. Didn't want to do both in the same PR though, as moving the num_hash_threads will have a lot of plumbing changes.
roryharr
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AccountsDb no longer has a thread pool for hashing accounts, but
accounts_db.rsis still where we create the hashing thread pool used for startup accounts verification.Summary of Changes
Move the code for creating the thread pool into the verification fn.