Skip to content

Rename upsert reclaims accounts index test default define#7325

Merged
roryharr merged 1 commit intoanza-xyz:masterfrom
roryharr:rename_reclaims_accounts_index_test_default
Aug 5, 2025
Merged

Rename upsert reclaims accounts index test default define#7325
roryharr merged 1 commit intoanza-xyz:masterfrom
roryharr:rename_reclaims_accounts_index_test_default

Conversation

@roryharr
Copy link
Copy Markdown

@roryharr roryharr commented Aug 5, 2025

This is Pull Request 4 in a series to add support to upsert for obsolete accounts.

Problem

Changing the test default behaviour for accounts_index requires significant changes making reviews difficult

Summary of Changes

  • rename UPSERT_POPULATE_RECLAIMS to UPSERT_RECLAIM_TEST_DEFAULT
  • no other changes

Fixes #

@roryharr roryharr force-pushed the rename_reclaims_accounts_index_test_default branch from ea21115 to d68c568 Compare August 5, 2025 17:25
@roryharr roryharr requested a review from brooksprumo August 5, 2025 17:25
@roryharr roryharr marked this pull request as ready for review August 5, 2025 17:25
Copy link
Copy Markdown

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.8%. Comparing base (1286a6a) to head (d68c568).
⚠️ Report is 2690 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7325   +/-   ##
=======================================
  Coverage    82.8%    82.8%           
=======================================
  Files         801      801           
  Lines      363318   363318           
=======================================
+ Hits       300877   300923   +46     
+ Misses      62441    62395   -46     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roryharr roryharr merged commit e5eb344 into anza-xyz:master Aug 5, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants