SPL: Use token interface crate#7311
Conversation
|
If this PR represents a change to the public RPC API:
Thank you for keeping the RPC clients in sync with the server API @rustopian. |
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looking good so far! Just a couple of little things that I noticed
| solana_test_validator::TestValidator, | ||
| spl_token::{ | ||
| spl_token_interface::{ | ||
| solana_program::program_pack::Pack, |
There was a problem hiding this comment.
We'll probably need to import this ourselves in this file, since the interface doesn't re-export whole crates like the program crate does
There was a problem hiding this comment.
Absolutely. Search-and-replace still awaiting manual check & fixup here and a couple of other places, just wanted to grab that spot in the SDK V3 project with this draft before the night was out:D
will wrap tomorrow
There was a problem hiding this comment.
This script is super out of date, and made sense when all of the SPL crates were hosted in the same SPL repo, so let's just leave it as is
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7311 +/- ##
=========================================
+ Coverage 83.0% 83.2% +0.1%
=========================================
Files 801 800 -1
Lines 362250 361470 -780
=========================================
+ Hits 300776 300805 +29
+ Misses 61474 60665 -809 🚀 New features to boost your workflow:
|
4 participants
Problem
As outlined in 7256, we need to get Agave off of crates that depend back on Agave.
spl-token is one of those crates.
Summary of changes
Use spl-token-interface instead.