Blockstore: fix last tests using legacy shreds#7308
Merged
alexpyattaev merged 2 commits intoanza-xyz:masterfrom Aug 5, 2025
Merged
Blockstore: fix last tests using legacy shreds#7308alexpyattaev merged 2 commits intoanza-xyz:masterfrom
alexpyattaev merged 2 commits intoanza-xyz:masterfrom
Conversation
alexpyattaev
changed the title
alexpyattaev
commented
Aug 4, 2025
| &mut ProcessShredsStats::default(), | ||
| ) | ||
| .unwrap() | ||
| .next() |
Author
There was a problem hiding this comment.
we generate full FEC set as usual but only pick the first shred, which should have the exact index we need.
alexpyattaev
commented
Aug 4, 2025
| ShredFlags::empty(), | ||
| 0, // reference_tick, | ||
| 0, // version | ||
| fec_set_index + 30, |
Author
There was a problem hiding this comment.
this +30 here seems a bit odd here, not sure what it is trying to achieve.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7308 +/- ##
=========================================
- Coverage 82.8% 82.8% -0.1%
=========================================
Files 801 801
Lines 363392 363432 +40
=========================================
- Hits 301027 300991 -36
- Misses 62365 62441 +76 🚀 New features to boost your workflow:
|
steviez
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Legacy shreds need to go #5982
Summary of Changes