SPL: Use spl-memo-interface crate#7291
Merged
joncinque merged 1 commit intoanza-xyz:masterfrom Aug 4, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7291 +/- ##
=========================================
- Coverage 82.8% 82.8% -0.1%
=========================================
Files 801 801
Lines 363392 363408 +16
=========================================
- Hits 301027 300957 -70
- Misses 62365 62451 +86 🚀 New features to boost your workflow:
|
#### Problem As outlined in solana-labs#7256, we need to get Agave off of crates that depend back on Agave. spl-memo is one of those crates #### Summary of changes Use spl-memo-interface instead. The only difference is that `build_memo` takes in a program id, which is used in one test.
joncinque
force-pushed
the
memo-interface
branch
from
d87f82f to
1385f75
Compare
Author
|
Sorry, can I get another approval? Had to rebase after the instruction-padding change went in |
rustopian
approved these changes
Aug 4, 2025
rustopian
left a comment
rustopian
left a comment
There was a problem hiding this comment.
Sure thing. No PR content has changed; relying on CI to confirm everything still passes.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As outlined in #7256, we need to get Agave off of crates that depend back on Agave.
spl-memo is one of those crates
Summary of changes
Use spl-memo-interface instead. The only difference is that
build_memotakes in a program id, which is used in one test.