Remove index_in_callee from InstructionAccount#7263
Merged
LucasSte merged 9 commits intoanza-xyz:masterfrom Aug 6, 2025
Merged
Remove index_in_callee from InstructionAccount#7263LucasSte merged 9 commits intoanza-xyz:masterfrom
index_in_callee from InstructionAccount#7263LucasSte merged 9 commits intoanza-xyz:masterfrom
Conversation
|
The Firedancer team maintains a line-for-line reimplementation of the |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7263 +/- ##
========================================
Coverage 83.0% 83.0%
========================================
Files 801 801
Lines 362242 362439 +197
========================================
+ Hits 300807 300987 +180
- Misses 61435 61452 +17 🚀 New features to boost your workflow:
|
Lichtso
reviewed
Aug 1, 2025
Lichtso
reviewed
Aug 1, 2025
Lichtso
reviewed
Aug 1, 2025
Lichtso
reviewed
Aug 1, 2025
index_in_callee from InstructionContextindex_in_callee from InstructionAccount
Lichtso
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In SIMD-0177, we want
InstructionContextto have onlyindex_in_transaction,is_signerandis_writable. We must, then, removeindex_in_callee.Summary of Changes
prepare_next_to_level_instruction, and inprepare_next_instructionfor detecting duplicated accounts and retrieving the index_in_instruction from the index_in_transaction.fn configurenow receives the aforementioned map as an argument, so I cratedfn configure_for_testto facilitate the usage in tests.