Renaming work sequence to work id for dependency tracking#7250
Merged
lijunwangs merged 1 commit intoanza-xyz:masterfrom Aug 27, 2025
Merged
Renaming work sequence to work id for dependency tracking#7250lijunwangs merged 1 commit intoanza-xyz:masterfrom
lijunwangs merged 1 commit intoanza-xyz:masterfrom
Conversation
|
If this PR represents a change to the public RPC API:
Thank you for keeping the RPC clients in sync with the server API @lijunwangs. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7250 +/- ##
=========================================
- Coverage 82.8% 82.8% -0.1%
=========================================
Files 803 803
Lines 364392 364392
=========================================
- Hits 302035 301995 -40
- Misses 62357 62397 +40 🚀 New features to boost your workflow:
|
alannza
approved these changes
Aug 27, 2025
alannza
left a comment
There was a problem hiding this comment.
Thanks for tweaking this. Left a minor comment inline.
Comment on lines
+27
to
+30
| /// Notify all waiting threads that a work has been processed with the given work id. | ||
| /// This function will update the processed work id and notify all waiting threads only if the work | ||
| /// id is greater than the procsessed work id. Notify a work of id number 's' will | ||
| /// implicitly imply that all work with id number less than 's' have been processed. |
There was a problem hiding this comment.
This comment didn't survive the rename, it doesn't make much sense anymore. How about something like this?:
Suggested change
| /// Notify all waiting threads that a work has been processed with the given work id. | |
| /// This function will update the processed work id and notify all waiting threads only if the work | |
| /// id is greater than the procsessed work id. Notify a work of id number 's' will | |
| /// implicitly imply that all work with id number less than 's' have been processed. | |
| /// Notify all waiting threads that work has been processed with the given work id. | |
| /// This function will notify all waiting threads only if they don't have unfinished work as a dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Summary of Changes
Address a follow-up comment on work sequence, rename it to work id
Fixes #