v1.17: default staked client in LocalCluster (backport of #716)#723
Merged
v1.17: default staked client in LocalCluster (backport of #716)#723
Conversation
* default staked client in LocalCluster * fix underflow (cherry picked from commit e91a5e2) # Conflicts: # local-cluster/tests/local_cluster.rs
Author
|
Cherry-pick of e91a5e2 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
If merge this first, can rebase #696 with the removed test re-added. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.17 #723 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 806 806
Lines 219284 219284
=======================================
+ Hits 179002 179033 +31
+ Misses 40282 40251 -31 |
t-nelson
approved these changes
Apr 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Summary of Changes
Fixes #
This is an automatic backport of pull request #716 done by [Mergify](https://mergify.com).