gossip: refactor cluster_info #5824#7228
Merged
alexpyattaev merged 2 commits intoanza-xyz:masterfrom Aug 5, 2025
Merged
Conversation
KirillLykov
reviewed
Jul 30, 2025
| //! | ||
| //! Bank needs to provide an interface for us to query the stake weight | ||
|
|
||
| pub use crate::node::Node; |
There was a problem hiding this comment.
I guess this is to avoid breaking public API. @puhtaytow can't we break it because we bump major version?
Author
There was a problem hiding this comment.
Yes, that was the reason. Thank you for the suggestion.
KirillLykov
previously approved these changes
Jul 30, 2025
KirillLykov
left a comment
KirillLykov
left a comment
There was a problem hiding this comment.
To me looks good: this PR moves the Node code into new module without unnecessary changes.
|
Ok with no reexport the diff is kinda huge but I guess this is the price we have to pay... |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7228 +/- ##
=========================================
- Coverage 83.1% 83.1% -0.1%
=========================================
Files 850 851 +1
Lines 369949 370108 +159
=========================================
+ Hits 307739 307764 +25
- Misses 62210 62344 +134 🚀 New features to boost your workflow:
|
KirillLykov
approved these changes
Aug 5, 2025
|
@alexpyattaev are we good to go? |
alexpyattaev
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This is first PR of the #5824
Summary of Changes
cluster_info::Nodehas been moved to separate module.