metrics: don't make threads which submit metrics syscall to wake up#7196
Merged
alessandrod merged 1 commit intoanza-xyz:masterfrom Aug 4, 2025
Merged
metrics: don't make threads which submit metrics syscall to wake up#7196alessandrod merged 1 commit intoanza-xyz:masterfrom
alessandrod merged 1 commit intoanza-xyz:masterfrom
Conversation
steviez
reviewed
Jul 28, 2025
alessandrod
force-pushed
the
metrics-dont-sleep
branch
from
77354b3 to
031d07f
Compare
Sleep without needing a notify.
alessandrod
force-pushed
the
metrics-dont-sleep
branch
from
031d07f to
b3c3c55
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7196 +/- ##
=========================================
Coverage ? 82.8%
=========================================
Files ? 803
Lines ? 363699
Branches ? 0
=========================================
Hits ? 301248
Misses ? 62451
Partials ? 0 🚀 New features to boost your workflow:
|
steviez
approved these changes
Aug 4, 2025
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
Makes sense given that we have so many threads all submitting datapoints
roryharr
added a commit
to roryharr/agave-sandbox
that referenced
this pull request
Aug 5, 2025
…ake up (anza-xyz#7196)" This reverts commit 0c42e18.
roryharr
added a commit
to roryharr/agave-sandbox
that referenced
this pull request
Aug 5, 2025
…all to wake up (anza-xyz#7196)"" This reverts commit 7014c7b.
roryharr
added a commit
to roryharr/agave-sandbox
that referenced
this pull request
Aug 5, 2025
…ake up (anza-xyz#7196)" This reverts commit 0c42e18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This thing is causing threads which submit metrics to do syscalls to wake up the metric submit thread. Make the submit thread sleep on a timer so that it doesn't need to be woken up ffs.