turbine: migrate bench and test to non-overlapping ports#7179
Merged
lijunwangs merged 2 commits intoanza-xyz:masterfrom Aug 5, 2025
Merged
turbine: migrate bench and test to non-overlapping ports#7179lijunwangs merged 2 commits intoanza-xyz:masterfrom
lijunwangs merged 2 commits intoanza-xyz:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7179 +/- ##
=========================================
Coverage ? 83.2%
=========================================
Files ? 853
Lines ? 373995
Branches ? 0
=========================================
Hits ? 311518
Misses ? 62477
Partials ? 0 🚀 New features to boost your workflow:
|
lijunwangs
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A bunch of tests still relies on either hardcoded ports or bind_to_localhost and bind_to_unspecified. This creates flaky tests in cases where unique port ranges are needed.
This PR is the step in the journey toward resolving the issue.
Related to #7055
Summary of Changes
broadcast_shreds_benchhas been moved tobind_to_localhost_unique.setupas well.