bench-streamer: move to non-overlapping ports#7177
Closed
puhtaytow wants to merge 1 commit intoanza-xyz:masterfrom
Closed
bench-streamer: move to non-overlapping ports#7177puhtaytow wants to merge 1 commit intoanza-xyz:masterfrom
puhtaytow wants to merge 1 commit intoanza-xyz:masterfrom
Conversation
|
@steviez this might be something you can take a look at |
|
The comment Alex made here is applicable on this PR as well: #7180 (comment). Namely, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A bunch of code still relies on either hardcoded ports or bind_to_localhost and bind_to_unspecified. This creates flaky tests in cases where unique port ranges are needed.
This PR is the step in the journey toward resolving the issue.
Related to #7055
Summary of Changes
Function producer has been moved from
bind_to_unspecifiedto the newbind_to_localhost_unique.