Skip to content

remove stale integration tests that are not used#7166

Merged
alexpyattaev merged 2 commits intoanza-xyz:masterfrom
alexpyattaev:axe_netem
Aug 28, 2025
Merged

remove stale integration tests that are not used#7166
alexpyattaev merged 2 commits intoanza-xyz:masterfrom
alexpyattaev:axe_netem

Conversation

@alexpyattaev
Copy link
Copy Markdown

Problem

  • We have a bunch of integration tests relying on GCE scripts that have not been used /maintained in a while.
  • Keeping them in the repo achieves nothing

Summary of Changes

  • Axe legacy files

To consider: we probably need a reasonable way to achieve similar results for alpenglow without reinventing the wheel and with far fewer lines of bash.

@alexpyattaev alexpyattaev force-pushed the axe_netem branch 3 times, most recently from 477e2c7 to 0f85682 Compare July 25, 2025 10:27
@alexpyattaev alexpyattaev requested a review from yihau July 25, 2025 10:34
@yihau yihau requested a review from t-nelson July 25, 2025 11:16
@t-nelson
Copy link
Copy Markdown

@yihau are these the ones that we pulled out of pr ci to nightly ci, then no one ever looked at them again, so we stopped running them?

@yihau
Copy link
Copy Markdown
Member

yihau commented Jul 28, 2025

yeah, I think so. the following nightly runs have been stopped:

  • system-test/performance-testcases/gce-cpu-only-perf-5-node.yml
  • system-test/stability-testcases/gce-perf-stability-5-node-single-region.yml
  • system-test/partition-testcases/gce-5-node-3-partition.yml (run with system-test/netem-configs/partial-loss-three-partitions)
  • system-test/partition-testcases/gce-5-node-single-region-2-partitions.yml (run with system-test/netem-configs/complete-loss-two-partitions)
  • system-test/partition-testcases/gce-partition-once-then-stabilize.yml (run with system-test/netem-configs/partial-loss-three-partitions)

I couldn’t find the older records since they were in the labs' buildkite project. but iirc, when we were still labs, we also ran some of the other uncover files

@alexpyattaev
Copy link
Copy Markdown
Author

but iirc, when we were still labs, we also ran some of the other uncover files

What are the uncover files?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.0%. Comparing base (dda8b79) to head (844e8ba).
⚠️ Report is 2337 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #7166     +/-   ##
=========================================
- Coverage    83.0%    83.0%   -0.1%     
=========================================
  Files         812      812             
  Lines      356963   356963             
=========================================
- Hits       296593   296588      -5     
- Misses      60370    60375      +5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yihau
Copy link
Copy Markdown
Member

yihau commented Jul 28, 2025

oh, I mean the files that I didn't mention earlier. like system-test/netem-configs/complete-loss-four-partitions, system-test/partition-testcases/gce-partition-recovery.yml...

@alexpyattaev alexpyattaev marked this pull request as ready for review July 28, 2025 13:08
@alexpyattaev
Copy link
Copy Markdown
Author

So, let us axe this then? We can always resurrect it later if needed.

t-nelson
t-nelson previously approved these changes Aug 21, 2025
@alexpyattaev
Copy link
Copy Markdown
Author

@t-nelson had to rebase due to conflicts in Cargo.toml files that were to be removed by this PR.

@alexpyattaev alexpyattaev added the automerge automerge Merge this Pull Request automatically once CI passes label Aug 28, 2025
@alexpyattaev alexpyattaev merged commit 5a1ad60 into anza-xyz:master Aug 28, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge automerge Merge this Pull Request automatically once CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants