Skip to content

Revert "build(deps): bump curve25519-dalek from 4.1.3 to 4.2.0 (#6914)"#7144

Closed
apfitzge wants to merge 2 commits intoanza-xyz:masterfrom
apfitzge:proper_revert_commits_dalek
Closed

Revert "build(deps): bump curve25519-dalek from 4.1.3 to 4.2.0 (#6914)"#7144
apfitzge wants to merge 2 commits intoanza-xyz:masterfrom
apfitzge:proper_revert_commits_dalek

Conversation

@apfitzge
Copy link
Copy Markdown

Problem

Summary of Changes

Fixes #

@apfitzge apfitzge marked this pull request as ready for review July 24, 2025 16:30
@apfitzge
Copy link
Copy Markdown
Author

apfitzge commented Jul 24, 2025

master:
test bench_arc_mutex_poh_batched_hash            ... bench:   1,499,001.10 ns/iter (+/- 4,711.12)

PR:
test bench_arc_mutex_poh_batched_hash            ... bench:   1,389,605.20 ns/iter (+/- 4,989.74)

around a 8% performance improvement by doing proper revert. this seems to be consistent with the degredation observed in the validator.

@apfitzge
Copy link
Copy Markdown
Author

apfitzge commented Jul 24, 2025

can split this into 2 prs as well so each of the previously merged PRs has a clean revert commit.
@steviez and/or @t-nelson wdyt is the better way?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.2%. Comparing base (86d14f6) to head (7763955).
⚠️ Report is 2754 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7144   +/-   ##
=======================================
  Coverage    83.2%    83.2%           
=======================================
  Files         853      853           
  Lines      373926   373926           
=======================================
+ Hits       311358   311394   +36     
+ Misses      62568    62532   -36     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@steviez
Copy link
Copy Markdown

steviez commented Jul 24, 2025

can split this into 2 prs as well so each of the previously merged PRs has a clean revert commit. @steviez and/or @t-nelson wdyt is the better way?

Thanks for tracking this down. I'm leaning towards separate PR's for the reason you stated; marginally more work but will hopefully avoid further confusion + will help pump your GH commit numbers :trollface:

@apfitzge apfitzge closed this Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants