Revert "build(deps): bump curve25519-dalek from 4.1.3 to 4.2.0 (#6914)"#7144
Closed
apfitzge wants to merge 2 commits intoanza-xyz:masterfrom
Closed
Revert "build(deps): bump curve25519-dalek from 4.1.3 to 4.2.0 (#6914)"#7144apfitzge wants to merge 2 commits intoanza-xyz:masterfrom
apfitzge wants to merge 2 commits intoanza-xyz:masterfrom
Conversation
This reverts commit d1e9a3e.
Author
around a 8% performance improvement by doing proper revert. this seems to be consistent with the degredation observed in the validator. |
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7144 +/- ##
=======================================
Coverage 83.2% 83.2%
=======================================
Files 853 853
Lines 373926 373926
=======================================
+ Hits 311358 311394 +36
+ Misses 62568 62532 -36 🚀 New features to boost your workflow:
|
Thanks for tracking this down. I'm leaning towards separate PR's for the reason you stated; marginally more work but will hopefully avoid further confusion + will help pump your GH commit numbers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
git revertcpufeaturesfrom0.2.7to0.2.17Summary of Changes
Fixes #