SIMD-0266: Efficient Token program#7125
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7125 +/- ##
========================================
Coverage 83.2% 83.2%
========================================
Files 863 864 +1
Lines 374519 375041 +522
========================================
+ Hits 311611 312144 +533
+ Misses 62908 62897 -11 🚀 New features to boost your workflow:
|
buffalojoec
left a comment
There was a problem hiding this comment.
The v2 target implementation is looking great! I reviewed the migration path, but haven't checked the tests yet since it's still a draft.
I was waiting for CI to pass – all good now! 😊 |
joncinque
left a comment
There was a problem hiding this comment.
Looks good to me, once Joe's last comment is addressed!
buffalojoec
left a comment
There was a problem hiding this comment.
Looks good to me, just need a feature-set rebase & CI to pass!
I think maybe, just to be insanely careful, we should also add a test with live transactions and a valid "stub" ELF. I did a few of these over here:
e6476a2 to
63c8eea
Compare
buffalojoec
left a comment
There was a problem hiding this comment.
Changes look good on my side, but I'd still love to see a stub test as I mentioned up here.
63c8eea to
8544810
Compare
buffalojoec
left a comment
There was a problem hiding this comment.
Looking good, but let's reduce some redundancy.
70f5922 to
e9ebc2b
Compare
ca097c2 to
a3c6d39
Compare
buffalojoec
left a comment
There was a problem hiding this comment.
I think this looks great! Just get @Lichtso's sign off on the cache step. Otherwise g2g from my side.
50e195d to
45770bc
Compare
Problem
SIMD-0266 proposes to replace the current verion of SPL Token with p-token.
Summary of Changes
This PR includes the following changes:
agave-feature-setand its activation onbank.rs, which uses themigrate_bpf_loader_v2_to_v3to replace the SPL Token program data.The feature activation and migration of the account have been tested using a Core BPF migration CLI fork:
Logs from the test validator:
Additionally, it was also tested using a "p-token migration simulator" tool.
Before the upgrade of SPL Token program:
After the feature is activated and the program upgraded:
Note
When the feature is activated and the program is swapped, it stays in
DelayVisibilityfor1slot – the first slot of the epoch after the feature activation – which means that any transaction executing SPL Token instructions will fail during that slot.