thin-client: Remove deprecated module

[fkouteib]

Problem

Thin-client has been deprecated since v2.0.0 (Solana Labs PR).

Summary of Changes

Remove deprecated module from the code base.

[steviez]

LGTM but let's wait for @gregcusack to take a look too; he did the deprecation work so want to give him a chance to chime in before we rip this out

[gregcusack]

thank you for doing this!! Looks mostly good. I would just remove all references to ThinClient, thin-client, thin_client, thin client, etc from the repo.

a few spots where there are still references:

1. https://github.com/fkouteib/agave/blob/remove_thin_client/bench-tps/src/cli.rs
2. https://github.com/fkouteib/agave/blob/remove_thin_client/docs/src/implemented-proposals/testing-programs.md
3. https://github.com/fkouteib/agave/blob/remove_thin_client/docs/src/proposals/rust-clients.md

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.2%. Comparing base (c5b2d3a) to head (83c4123).
⚠️ Report is 2739 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #7115    +/-   ##
========================================
  Coverage    83.1%    83.2%            
========================================
  Files         849      847     -2     
  Lines      369954   369452   -502     
========================================
- Hits       307735   307648    -87     
+ Misses      62219    61804   -415     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[fkouteib]

All requested changes have been addressed.

[steviez]

All requested changes have been addressed.

I was kind of deferring to @gregcusack, but I think he may be unavailable this week. I guess the main comment from him was making sure we deleted all remaining references to thin-client. Aside from the ones he called out, I assume you have searched the rest of the codebase to look for any lingering comments or whatever ?

[fkouteib]

All requested changes have been addressed.

I was kind of deferring to @gregcusack, but I think he may be unavailable this week. I guess the main comment from him was making sure we deleted all remaining references to thin-client. Aside from the ones he called out, I assume you have searched the rest of the codebase to look for any lingering comments or whatever ?

Yes, sir. All instances across variations have been removed. And yes I'm fine waiting for Greg to do a second pass review.

[gregcusack]

lgtm! thanks legend!