Skip to content

thread-manager: Resolve Rust 1.88 clippy lints and format strings#7088

Merged
steviez merged 2 commits intoanza-xyz:masterfrom
steviez:rust_1.88_tm
Jul 22, 2025
Merged

thread-manager: Resolve Rust 1.88 clippy lints and format strings#7088
steviez merged 2 commits intoanza-xyz:masterfrom
steviez:rust_1.88_tm

Conversation

@steviez
Copy link
Copy Markdown

@steviez steviez commented Jul 22, 2025

Problem

Working towards #6850, broken out from #6854

Summary of Changes

  • Run cargo clippy --fix --tests with Rust 1.88.0 set in rust-toolchain.toml
    • These should only be instances of uninlined_format_args
  • Run cargo fmt with format_strings = true set in rustfmt.toml

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.2%. Comparing base (64382a5) to head (aa0f8a0).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #7088     +/-   ##
=========================================
- Coverage    83.3%    83.2%   -0.1%     
=========================================
  Files         854      854             
  Lines      374711   374713      +2     
=========================================
- Hits       312197   312109     -88     
- Misses      62514    62604     +90     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@steviez steviez requested a review from alexpyattaev July 22, 2025 20:52
Copy link
Copy Markdown

@alexpyattaev alexpyattaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@steviez steviez merged commit 222d32e into anza-xyz:master Jul 22, 2025
41 checks passed
@steviez steviez deleted the rust_1.88_tm branch July 22, 2025 21:08
puhtaytow pushed a commit to puhtaytow/agave that referenced this pull request Jul 24, 2025
…za-xyz#7088)

- Run `cargo clippy --fix --tests` with Rust 1.88.0 set in `rust-toolchain.toml`
- Run `cargo fmt` with `format_strings = true` set in `rustfmt.toml`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants