Skip to content

perf: Resolve Rust 1.88 clippy lints and format strings#7044

Merged
steviez merged 2 commits intoanza-xyz:masterfrom
steviez:rust_1.88_perf
Jul 22, 2025
Merged

perf: Resolve Rust 1.88 clippy lints and format strings#7044
steviez merged 2 commits intoanza-xyz:masterfrom
steviez:rust_1.88_perf

Conversation

@steviez
Copy link
Copy Markdown

@steviez steviez commented Jul 18, 2025

Problem

Working towards #6850, broken out from #6854

Summary of Changes

  • Run cargo clippy --fix --tests with Rust 1.88.0 set in rust-toolchain.toml
    • These should only be instances of uninlined_format_args
  • Run cargo fmt with format_strings = true set in rustfmt.toml

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 18, 2025

Codecov Report

❌ Patch coverage is 27.58621% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.2%. Comparing base (c87ab7c) to head (869dcbf).
⚠️ Report is 2834 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #7044     +/-   ##
=========================================
- Coverage    83.2%    83.2%   -0.1%     
=========================================
  Files         853      853             
  Lines      374734   374735      +1     
=========================================
- Hits       311896   311867     -29     
- Misses      62838    62868     +30     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@steviez steviez requested review from bw-solana and sakridge July 20, 2025 23:28
Copy link
Copy Markdown

@bw-solana bw-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steviez steviez merged commit 22f2f6d into anza-xyz:master Jul 22, 2025
41 checks passed
@steviez steviez deleted the rust_1.88_perf branch July 22, 2025 00:54
puhtaytow pushed a commit to puhtaytow/agave that referenced this pull request Jul 24, 2025
- Run `cargo clippy --fix --tests` with Rust 1.88.0 set in `rust-toolchain.toml`
- Run `cargo fmt` with `format_strings = true` set in `rustfmt.toml`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants