Skip to content

Invert Index in caller and index in transaction in the serialization benchmark#7026

Merged
LucasSte merged 1 commit into
anza-xyz:masterfrom
LucasSte:fix-indexes
Jul 18, 2025
Merged

Invert Index in caller and index in transaction in the serialization benchmark#7026
LucasSte merged 1 commit into
anza-xyz:masterfrom
LucasSte:fix-indexes

Conversation

@LucasSte
Copy link
Copy Markdown

Problem

In #6829, I refactored InstructionAccount and created a constructor for it. As a consequence, we don't have named fields anymore during initialization and we must pass the arguments to the constructor in the correct order.

In my refactor, I did not pay attention to one case where the initialization of the struct members did not follow the same order of the constructor parameters. See https://github.com/anza-xyz/agave/pull/6829/files#diff-4d03f27ca1e78f3acca722a473b99537c734ec252882d32681cb88a29e727365R95-R102.

Summary of Changes

Invert the indexes for the correct usage.

@LucasSte LucasSte requested a review from Lichtso July 17, 2025 20:42
@LucasSte LucasSte marked this pull request as ready for review July 17, 2025 20:42
@LucasSte LucasSte requested a review from a team as a code owner July 17, 2025 20:42
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.2%. Comparing base (b4ba976) to head (3229b46).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7026   +/-   ##
=======================================
  Coverage    83.2%    83.2%           
=======================================
  Files         853      853           
  Lines      375129   375129           
=======================================
+ Hits       312239   312253   +14     
+ Misses      62890    62876   -14     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucasSte LucasSte merged commit 10ca0a0 into anza-xyz:master Jul 18, 2025
41 checks passed
@LucasSte LucasSte deleted the fix-indexes branch July 18, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants