Invert Index in caller and index in transaction in the serialization benchmark#7026
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7026 +/- ##
=======================================
Coverage 83.2% 83.2%
=======================================
Files 853 853
Lines 375129 375129
=======================================
+ Hits 312239 312253 +14
+ Misses 62890 62876 -14 🚀 New features to boost your workflow:
|
Lichtso
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In #6829, I refactored
InstructionAccountand created a constructor for it. As a consequence, we don't have named fields anymore during initialization and we must pass the arguments to the constructor in the correct order.In my refactor, I did not pay attention to one case where the initialization of the struct members did not follow the same order of the constructor parameters. See https://github.com/anza-xyz/agave/pull/6829/files#diff-4d03f27ca1e78f3acca722a473b99537c734ec252882d32681cb88a29e727365R95-R102.
Summary of Changes
Invert the indexes for the correct usage.