Skip to content

Generate toolchain name inside condition#7024

Merged
LucasSte merged 1 commit intoanza-xyz:masterfrom
LucasSte:relocate-name
Jul 17, 2025
Merged

Generate toolchain name inside condition#7024
LucasSte merged 1 commit intoanza-xyz:masterfrom
LucasSte:relocate-name

Conversation

@LucasSte
Copy link
Copy Markdown

Problem

Rustup may not be available in nix-environments, so we cannot rely on it for generating the toolchain name. See the comment in #6981 (comment).

Summary of Changes

Only generate the toolchain name if we are not overriding rustup.

@LucasSte LucasSte mentioned this pull request Jul 17, 2025
@LucasSte LucasSte requested a review from joncinque July 17, 2025 19:40
@LucasSte LucasSte marked this pull request as ready for review July 17, 2025 19:40
Copy link
Copy Markdown

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.2%. Comparing base (b4ba976) to head (434493d).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #7024     +/-   ##
=========================================
- Coverage    83.2%    83.2%   -0.1%     
=========================================
  Files         853      853             
  Lines      375129   375129             
=========================================
- Hits       312239   312214     -25     
- Misses      62890    62915     +25     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucasSte LucasSte merged commit 58d7da6 into anza-xyz:master Jul 17, 2025
41 checks passed
@LucasSte LucasSte deleted the relocate-name branch July 17, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants