SIMD-0321: Provide pointer to instruction data in VM r2#7009
SIMD-0321: Provide pointer to instruction data in VM r2#7009buffalojoec merged 4 commits intoanza-xyz:masterfrom
Conversation
|
The Firedancer team maintains a line-for-line reimplementation of the |
b101644 to
f4bead8
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7009 +/- ##
=========================================
- Coverage 82.9% 82.9% -0.1%
=========================================
Files 823 823
Lines 360873 360908 +35
=========================================
+ Hits 299369 299381 +12
- Misses 61504 61527 +23 🚀 New features to boost your workflow:
|
4664397 to
2d9863a
Compare
53b4a39 to
51d13cd
Compare
51d13cd to
dbcc742
Compare
|
|
||
| #[no_mangle] | ||
| pub unsafe extern "C" fn entrypoint(_input: *mut u8, instruction_data_addr: *const u8) -> u64 { | ||
| let instruction_data_len = *((instruction_data_addr as u64 - 8) as *const u64); |
There was a problem hiding this comment.
| let instruction_data_len = *((instruction_data_addr as u64 - 8) as *const u64); | |
| let instruction_data_len = *(instruction_data_addr.sub(8) as *const u64); |
There was a problem hiding this comment.
Can you guys give full reviews please, instead of these fly-by one-off comments? I'd rather just resolve everything once.
There was a problem hiding this comment.
I reviewed your entire PR. That was the only comment that I had.
dbcc742 to
2249bcf
Compare
Implementation of SIMD-0321, which provides a pointer to the instruction data in the VM's register 2.