Removes is_accounts_lt_hash_enabled()#7008
Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom Jul 17, 2025
Merged
Conversation
brooksprumo
commented
Jul 17, 2025
Comment on lines
-20
to
-23
| /// Returns if the accounts lt hash is enabled | ||
| pub fn is_accounts_lt_hash_enabled(&self) -> bool { | ||
| true | ||
| } |
Comment on lines
-483
to
-484
| // When removing the accounts lt hash featurization code, also remove this Option wrapper | ||
| pub accounts_lt_hash: Option<AccountsLtHash>, |
Author
There was a problem hiding this comment.
This was the other main fallout. We always have an AccountsLtHash now.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7008 +/- ##
=========================================
- Coverage 83.2% 83.2% -0.1%
=========================================
Files 853 853
Lines 375105 375074 -31
=========================================
- Hits 312275 312217 -58
- Misses 62830 62857 +27 🚀 New features to boost your workflow:
|
roryharr
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The fn
Bank::is_accounts_lt_hash_enabled()always returnstrue. It can be removed and have its callers cleaned up.Summary of Changes
Remove it and clean up callers.